Thomas Burette• 190
@tburette
Posted
Hello, Very good clean solution! There are a lot of things to take inspiration from :
- custom properties to define color fonts with well organized naming
- small negative letter spacing
- I noticed many things that you did right for the button that I did wrong. Your button goes down when you use it, not up. The shadow effect works not just on :hover but on :focus as well.
- Good implementation of BEM. It's weird to see it used for such a 'major' part of a page that is an entire section. However since the sections are simple it works well here. I imagine if sections were to evolve into something more complex the use of BEM on section would break down.
Personal preference : instead of grid-column: 1 / 3;, you could use grid-column: span 2;.
Marked as helpful
0
