Single Price Grid Challenge

Community feedback

• 

  Bishal Singh Deo🎮•1,440

  @Bishalsnghd07Posted 9 months ago

  Hi, @KierenLWoods 👋

  Congrats for completing this challenge 🎉

  Your solution looks nice💓

  I have few suggestions for you,

  1)First, give some padding on body. So, that your web page will look little more responsive in mobile view.

  2)Second, line-height should not be needed to be used in this challenge directly in body, it should be used in child container. By using line-height directly in body, it means you are giving your whole component this line-height, which is not good approach. For best practice I would recommend to use in the text where line-height needed not in the whole screen.

  3)In card-wrapper class, there is no need of use <p> 2 times, for best practice I would recommend you should use p tag only once and by giving some max-width it will work same. Also, you did same approach in 2nd card-wrapper class.

  By doing this changes, your solution will be semantic, best practice with better accessibility.

  Hope, this tips will help you!

  Happy coding❤️

  Marked as helpful

  0