Skip to content
Submitted almost 4 years ago

Single price flexbox, BEM, media queries

Michał•45
@MiLabuda
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Single price grid component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello. i have couple questions for You -If using of BEM is proper in this project? -If using of media querries in this project is correct? -Are there better ways to write such code? -Should I try to use CSS preprocessors like SCSS/SASS?

Thank you very much for your time.

Community feedback

  • Grace•31,270
    @grace-snowPosted almost 4 years ago

    Hi MiLabuda,

    I can't see all the content at the moment because you've used exact heights that are smaller than your content (I will add a screenshot to slack to show you what I see). If you change height to min- height 100vh that will help. But I also see lots of elements that don't need heights or widths defining on this.

    As for BEM, you're not using it correctly at the moment. I would try to learn more about it, or just use simple class names for now.

    For scss, by all means try it. It's up to personal preference what tools you prefer to use.

    One thing I would suggest is to try changing your markup so this solution can be done using css grid instead of flexbox. It's a two dimensional layout so is an ideal learning ground for grid.

    All the best with it

    1
    Michał•45
    @MiLabudaPosted almost 4 years ago

    @grace-snow Thank you very much

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord