Single Price Component with HTML and CSS

Community feedback

• 

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  • Responsive 💯

  • Instead of having multiple css files try to merge them in a main css file, it would impact a lot in the speed of loading.

  • Try to add accessibility features like aria, sr-only, title.

  aria : link

  .sr-only:link

  I hope you find this helpful.

  Happy coding😄

  Marked as helpful

  1

  ---

  

  Cor-Ina•250

  @CorinaMurgPosted over 1 year ago

  Hi @Nehal

  Thank you for your feedback! I know having multiple CSS files slows down performance, but as I am still learning how to work with a great amount of CSS code, I find it easy when I break it into multiple files. Once I get more comfortable in my coding, I will switch to just one file. Many thanks! Corina

  1
• 

  Gesiere•780

  @GesierePosted over 1 year ago

  Great Work, your layout is perfect so is your design, Where my issues stands, would be the colors not matching the actual design. Compare the design that was given look at the colors and note where they are not similar.

  While the your layout is fine, you are not matching the colors in the design, all the same great work.

  And agreeing with the comment above some box-shadow would make the card section more pronounce.

  Marked as helpful

  1

  ---

  

  Cor-Ina•250

  @CorinaMurgPosted over 1 year ago

  Hi @Gesiere,

  Thank you for your feedback! As I mentioned in my original post, I changed the design on purpose because the contrast ratio of the given colors does not comply with the a11y guidelines. I know my design is not as appealing, but I'm still working on finding a better color scheme.

  I did forget about the shadow, so I will add it now. Many thanks!

  0
• 

  devendra•70

  @devendra-altPosted over 1 year ago

  Hello @Cor-Ina, Great Work,

  I have some suggestions for you,

  • you can add box-shadow to the info card.
  • you can use the <article> tag in place of <main class="price"><main/>, it was a better choice from the website accessibility point-of-view.
  • you can use descriptive class names to make your code more maintainable and consistent.

  Marked as helpful

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0