Single price component using semantic HTML and grid CSS
Design comparison
Solution retrospective
I would appreciate in advance any suggestions for improving the HTML and CSS code and better ways to implement grid CSS.
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there 👋. Good job on completing the challenge !
I have one suggestion about your code that might interest you.
- Use
<ul>
and<li>
for the content under "Why Us": Since the content is a list of items, it's more semantically correct to use an unordered list (<ul>
) and list items (<li>
) instead of using paragraph (<p>
).
I hope you find it useful! 😄
Happy coding!
Marked as helpful2 - Use
- @danielmrz-devPosted 11 months ago
Hello @Sebascode20!
Your solution looks great!
I have a couple of suggestions for improvement:
- For semantic reasons, and since that is the main title of the screen, you can replace the
<h3>
with<h1>
.
The
<h1>
to<h6>
tags are used to define HTML headings.<h1>
defines the most important heading.<h6>
defines the least important heading. Only use one<h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>
, then use<h2>
, and so on.- Also, still about semantic HTML, the tag
header
is used for the header of the whole page, not for wrapping titles of smaller elements. I know it makes sense because it is the header of that element, but this tag is supposed to be used for headers of pages. And the same thing goes forfooter
. 😊
Other than those details, you did an excellent job!
Marked as helpful0 - For semantic reasons, and since that is the main title of the screen, you can replace the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord