Skip to content
Submitted almost 4 years ago

Single Price Component using Sass

SwGarcia•30
@Syhwh
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Single price grid component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I started learning sass and this is my first try, any feedback is more than welcome.

Community feedback

  • Dave•5,295
    @dwhensonPosted almost 4 years ago

    Hi - nice work @syhwh. This looks good on the screenshot and is nicely responsive. Just some small points to think about:

    1. It might be nice to include some :hover styling on the link/button - it doesn't appear to respond at the moment. Pointer: cursor is always nice too.

    2. You might want to think of breakpoints in a relative unit rather than px, see the second answer here for the issue: https://stackoverflow.com/questions/609517/why-em-instead-of-px (but I think there is still some debate about this still being a thing or not)

    3. I'm not 100% sure but I think that you have some margin-top on the main container on the mobile view but not on desktop? This is causing a bit of a jump between viewports - probably not a bit issue, but nice to keep things consistent if possible.

    I've not learnt SASS yet, so I'm not commenting on that!

    Sorry, just to add this article on media queries: https://zellwk.com/blog/media-query-units/ it's a bit old but I think that it's still relevant.

    2
    SwGarcia•30
    @SyhwhPosted almost 4 years ago

    @dwhenson, just wanna say thanks for taking time and review this, I really appreciate it. Thank you.

    0
    Dave•5,295
    @dwhensonPosted almost 4 years ago

    @Syhwh most welcome. Keep up the good work!!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord