Single page site using HTML, CSS and JS

Community feedback

• 

  Gowsalaya•170

  @GowsalayadeviPosted over 2 years ago

  thanks Daniel :)

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Gowsala, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • use header tag to wrap the navbar for improve the Accessibility and not also the slider/first section
  • add main tag and wrap all section tags for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • instead of using a for the buttons use button tag
  • to make it look as close to the design as possible create a section for the slider/first section and add height: 60vh property and flex for center the element inside it
  • in the mobile nav add border-radius: 1rem to menu class
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  0