Design comparison
SolutionDesign
Solution retrospective
Hi! I just completed this challenge, any feedback is welcome! Thanks 😊
Community feedback
- @johnnygerardPosted over 1 year ago
Hello Wiks,
I opened a pull request to improve your contact form.
Other suggestions:
- Use
@use
instead of@import
(see Sass documentation). - Add
stylePreprocessorOptions
key toangular.json
. This allows you to use shorter file paths in your Sass imports (Style preprocessor options). - Commit more often. In particular, your initial commit should be the initialization of the Angular project.
- Use conventional commits (optional). This is a convention followed by Angular and other developers.
- Overwrite the default Angular
README.md
with your own. You can use theREADME-template.md
from the starter files.
I hope you find this feedback useful.
One last thing I forgot to mention:
- For simple forms, it is better to use template-driven forms (ngModel directive). You will have less code to write and maintain.
Marked as helpful1@wiksmfPosted over 1 year agoHi @johnnygerard :D
Thanks so much for the feedback, the resources and the pull request.
I know that template-driven forms are easier and faster to write, but my goal was to practice reactive forms as I have trouble with them :)
0 - Use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord