Single Page Developer Portfolio

Community feedback

• 

  P

  Johnny Gérard•640

  @johnnygerardPosted over 1 year ago

  Hello Wiks,

  I opened a pull request to improve your contact form.

  Other suggestions:

  • Use @use instead of @import (see Sass documentation).
  • Add stylePreprocessorOptions key to angular.json. This allows you to use shorter file paths in your Sass imports (Style preprocessor options).
  • Commit more often. In particular, your initial commit should be the initialization of the Angular project.
  • Use conventional commits (optional). This is a convention followed by Angular and other developers.
  • Overwrite the default Angular README.md with your own. You can use the README-template.md from the starter files.

  I hope you find this feedback useful.

  One last thing I forgot to mention:

  • For simple forms, it is better to use template-driven forms (ngModel directive). You will have less code to write and maintain.

  Marked as helpful

  1

  ---

  

  Wiks•750

  @wiksmfPosted over 1 year ago

  Hi @johnnygerard :D

  Thanks so much for the feedback, the resources and the pull request.

  I know that template-driven forms are easier and faster to write, but my goal was to practice reactive forms as I have trouble with them :)

  0