Single Page Design using Javascript, HTML, CSS/SCSS

Community feedback

• 

  David•8,000

  @DavidMorgadePosted over 2 years ago

  Hello Nyrell congrats on finishing the challenge!

  Regarding your question about the slider, I will suggest you to use a external library that can help you a lot, you don't need to recreate the wheel in this case, you can use swiper.js, and create awesome Sliders in no-time, they have a good documentation and support for every framework (including, ofc, vanilla Javascript).

  The other thing that I think is falling a bit on your project is the layout for mobile devices, in your .grid-container for example, you are using a max-width: 414px wich is making your grid overlay from the screen, instead try using 768px wich is the limit for mobile screen sizes.

  Hope my feedback helps you, if you have any questions don't hesitate to ask, I will try to help you as much as I can!

  Marked as helpful

  0

  ---

  

  Nyrell Leonor•400

  @nyrellclPosted over 2 years ago

  @DavidMorgade

  Hello David,

  Thanks so much for the suggestions. I will definitely replace the slider code with swiper.js it'll help me practice with using external libraries more.

  Ah yes i had some minor issues with the responsive part. using 768px might just do the trick.

  Thanks again!

  0