Design comparison
Solution retrospective
Please review. I need your honest criticism
Community feedback
- @mickygingerPosted over 4 years ago
Hey Uchechukwu, this is great!
You've done a great job a keeping your HTML and CSS simple. My only criticism is that you are probably being a bit too specific with your selectors of you text box and button.
Since there's only one
input
and onebutton
on the page, you don't need to (and shouldn't) specify the[type=email]
and[type=submit]
. If the designer were to change the design in the future to add another field, you would probably want it to be styled in the same way. As a general rule, keep your selectors broad, then only make them more specific when you need to.Keep up the good work! 🎉
1@thisisobatePosted over 4 years ago@mickyginger Hi, Thanks a lot for the reviews. This was really helpful and I promise to apply all the changes accordingly. Thanks once again!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord