@Islandstone89
Posted
HTML:
-
Every webpage needs a
<main>that wraps all of the content, except for<header>andfooter>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap.containerin a<main>. -
The alt text should be written naturally, without using
-between the words. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor website). -
.attributionshould be a<footer>, and you should use<p>for the text inside.
CSS:
-
It is best practice to write CSS in a separate file, often called
style.css. Create one in the same folder as theindex.html, and link to it in the<head>:<link rel="stylesheet" href="style.css">. -
Including a CSS Reset at the top is good practice.
-
The card should have a white background.
-
Use the style guide to find the correct
font-family. -
Add around
1remofpaddingon thebody, so the card doesn't touch the edges on small screens. -
The
bodyis only as tall as its content, so it has no vertical space to center the card. Addmin-height: 100svh;onbody. -
Remove
flex-wrap: wrap, it is not needed. -
Remove all widths and heights in
px. -
Add a
max-widthof around20remon the card, to prevent it from getting too wide on larger screens. -
font-sizemust never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
On the image, add
display: blockandmax-width: 100%- the max-width prevents it from overflowing its container.
Marked as helpful
