Skip to content
Submitted 8 months ago

Simplistic QR-code Card

Adarsh•120
@Adarshpathak1
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am feeling like i have learnt html and css. Now it' s time for javascript

What challenges did you encounter, and how did you overcome them?

learn text -align

What specific areas of your project would you like help with?

Please review my code and Provide suggestions for improvement.

Community feedback

  • Øystein Håberg•10,710
    @Islandstone89Posted 8 months ago

    HTML:

    • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap .container in a <main>.

    • The alt text should be written naturally, without using - between the words. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor website).

    • .attribution should be a <footer>, and you should use <p> for the text inside.

    CSS:

    • It is best practice to write CSS in a separate file, often called style.css. Create one in the same folder as the index.html, and link to it in the <head>: <link rel="stylesheet" href="style.css">.

    • Including a CSS Reset at the top is good practice.

    • The card should have a white background.

    • Use the style guide to find the correct font-family.

    • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

    • The body is only as tall as its content, so it has no vertical space to center the card. Add min-height: 100svh; on body.

    • Remove flex-wrap: wrap, it is not needed.

    • Remove all widths and heights in px.

    • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

    • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

    • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord