Kawsar Ahmed Fahad• 2,680
@faha1999
Posted
Hello, Szabolcs Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:
- You might want to use semantic tags like the
<main>
to wrap your code, instead ofdiv
. like
<main>
<div class="main-card-container"></div>
<div class="attribution"></div>
</main>
This would help improve accessibility.
-
add a
hover
effect & smalltransition
it will be better. & make thecursor: pointer;
. -
- Instead of using
px
, use relative units likerem or em
to get better performance when the information on your page needs to be resized for multiple screens and devices.REM
andEM
apply to all sizes, not justfont-size
. You can code your entire page inpx
and then, at the very end, use the VsCode pluginpx to rem
to perform the automatic conversion px to rem
- Instead of using
I hope it will work. Happy coding.
0