Design comparison
Solution retrospective
N/A
What challenges did you encounter, and how did you overcome them?N/A
What specific areas of your project would you like help with?Any help would be greatly appreciated.
Community feedback
- @DylandeBruijnPosted 4 months ago
@YDawoud7
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution 🎉
- Use of semantic HTML elements
- Clear descriptive CSS classes
Things you could improve ✍️
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
Try experimenting with the CSS layout tool Flexbox, it will help you greatly structuring elements on your webpage.
-
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
Try wrapping your links in
a
tags with ahref
attribute so you get the default pointer cursor functionality. -
Try adding the hover animation for the links.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful0@YDawoud7Posted 4 months ago@DylandeBruijn Thanks a lot Dylan! Your reply was really helpful and I learned new things from it.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord