Simple Responsive Profile Card with HTML CSS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi, Ameya Deokule! 👋

  Well done on this challenge! 👍

  I think for this challenge, giving the card component a simple fixed width and letting its height be determined by its content will work well. The clamp and calc functions are definitely useful at times, but I don't think they are necessary in this case since no complex calculations need to be made for the dimensions of the card. 😉

  Also, I suggest considering using CSS background images to add and position the background images in this challenge. It'll keep those images out of your HTML, which will make your markup slightly cleaner, and I think it's easier to manage the images and CSS background images, then (since you won't have to worry about things like the images overflowing their container). You could try to use viewport units to position the background images in this challenge, too, (which will allow you to make it so that they do not move around so much when the size of the screen changes).

  Hope that helps. 🙂

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Ameya Deokule•355

  @ameyadeokulePosted over 3 years ago

  @ApplePieGiraffe Thanks I'll surely remember to implement these changes in my design. Thanks for taking the time to review my code.

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @ameyadeokule

  No problem! 👍

  Oh, and BTW, if you found these tips helpful, an upvote would be appreciated! ;)

  1