Simple Responsive IP Tracker App

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  Well done on completing this exciting solution, your project looks great. Here are a few tips as continue on this journey

  • A form control must have a label - that can be useful for assistive technology users - in this case to provide information on the purpose of the input that they are required to fill. A placeholder content is not good enough for that purpose.
  • Your heading elements must be in descending order - that is h1, h2, h3 etc, it is not recommended to have an h4 tag then followed by an h2 or h3 or h1. An h4 should be followed by an h5.

  Happy coding

  0

  ---

  

  Mainul Islam•30

  @main1479Posted over 3 years ago

  @ChamuMutezva Thank you so much for your feedback, I will fix this very soon.

  0
• 

  Abbas Saad•260

  @AbbasSaad27Posted over 3 years ago

  Hello Mainul Islam! Congratulations on completing your first Frontend Mentor challenge! :D It looks great and responds pretty nicely!! I just have a few things to suggest. The data from the Ip geolocation API is being logged to the console. Might wanna look into that. Also, I can't search using a domain name. You should add that since it says "Search for any IP address or domain" in the placeholder :D Overall it seems really nice. Keep coding and happy coding!! :D

  0

  ---

  

  Abbas Saad•260

  @AbbasSaad27Posted over 3 years ago

  @AbbasSaad27 BTW that loading animation is nice!!

  0

  

  Mainul Islam•30

  @main1479Posted over 3 years ago

  @AbbasSaad27 Thank you so much for your feedback, I have fixed those bugs.

  0