P
VictorGerfaud• 210
@JamesLaviron
Posted
- Does the solution include semantic HTML?
yes, it does.
- Is it accessible, and what improvements could be made?
It's accessible. However you should focus on the way we you use classes and css selectors. You could look at some articles about how css selectors work (see https://medium.com/@paulohfev/css-best-practices-you-should-know-374c388a00dd for example). The way you do it could lead to performance issues.
Maybe also look at BEM methodology and SASS. It will help you structure your html and css to make it more reusable and easy to maintain.
Nice work overall though :)
Does the layout look good on a range of screen sizes?
It looks good.
Is the code well-structured, readable, and reusable?
It's fine
Does the solution differ considerably from the design?
it's very close, great job!
Marked as helpful
0
