Simple rating page using basic HTML, CSS and basic JS
Design comparison
Solution retrospective
Finally, I have done it after learning some basic js.
What challenges did you encounter, and how did you overcome them?Some of the js is like "overthinking", I want it to be clear not messy and.
What specific areas of your project would you like help with?The number rating is not in the middle, I can't think of any solutions to center but if you can, it is really helpful! Thanks a lot!
Community feedback
- @R3ygoskiPosted 6 months ago
Hello James, first of all, congrats on finish this project.
A tip, your number is not in the middle because of the padding, I changed to this:
padding:15px 20px, and seems as it was solved. But well, I noticed you were using CSS inline, be cautious with that, because it's can override your styles in CSS external file, and this make even harder to give maintence to your code.About your HTML, it's very verbous, and I don't know if it's good to modify it here in this comment, so I will modify it, and send it in your Github Issues Tab.
And good job, your project is really good, just need some littles improvement, keep practicing and improving your skills, if something that I said was unclear, please, feel free to ask, and I will try to help in the best possible way.
Marked as helpful0@JamesWallison1Posted 6 months ago@R3ygoski That's so nice of you to say so! Thank you really much for spending time reviewing my code, don't know how to thank you for your huge contributions!
1@R3ygoskiPosted 6 months ago@JamesWallison1 I opened the issue, so, when you can, give it a look, and there's no need to thank me, always glad for helping others devs.
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord