Design comparison
Solution retrospective
// EDIT: I've implemented kirty's suggestions (in the comments) and centered the Thank you text, as well as added code that disables the submit button until a rating is chosen. Thank you kirty! ❤️
Hi!
This is my very first, ever, project that I've done fully on my own.
I've used ReactJS and Sass to build this component.
I definitely think I didn't use Sass to the fullest, however it was my first time using it, so I've used variables and nesting. Any feedback in regards to making the css file smaller are welcome.
I am also aware that I could have split the CSS styles for each component, however having looked into that, I would have to work with importing them, and I feel that this project is small enough it didn't warrant splitting the files up.
Community feedback
- @kirtymeenaPosted over 2 years ago
Hi, nice work completing this challenge. I have noticed few issues:
- Thank you text is not in the center.
- user should not be able to submit without selecting a rating, I am able to submit which I think is not correct. You can create a form and use onSubmit to check if the user has selected any number or not.
if you add the flip card effect on submitting it will look even better. Adding an active selector to a button makes it look nice when clicked on it.
apart from small issues, the design looks good just thank you text and text below it are not centered.
Keep coding.
Marked as helpful3@nikavolkPosted over 2 years ago@kirtymeena Thank you for great feedback!
I completely overlooked the centered Thank you text and will fix it.
I've implemented a check to see if no value has been selected at all and output it as such, but your suggestion of preventing a submit without choosing a rating in the first place makes way more sense. Will update the code. Thank you! ❤️
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord