Simple QR Design

Community feedback

• 

  raya•2,870

  @rayaattaPosted 10 months ago

  Hello SheikBazith 👋, congratulations on completing this challenge 🎉 I have some suggestions you might find useful. 1 It is better to keep your html and css in different files because separating them improves performance since the browser parses the html and caches the css on subsequent visits

  2 Every html document should have a main tag that encloses the main page contents change <div class="main"> To <main class="card"> This will change nothing visually but it makes all the difference. You can learn more about the main tag in this article

  3 Remove the <div class= "attribution"> from the main and change it to <footer class="attribution"> And wrap it's text inside a p element.

  I hope this helps

  Happy coding 🙃

  Marked as helpful

  0

  ---

  

  SheikBazith•240

  @SheikBazithPosted 10 months ago

  @rayaatta thank you for the suggestion. I will keep those in mind while doing other projects.

  1