Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Simple QR Design

@SheikBazith

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any suggestion on how to code more efficiently would be greatly appreciated.

Community feedback

raya 2,850

@rayaatta

Posted

Hello SheikBazith 👋, congratulations on completing this challenge 🎉 I have some suggestions you might find useful. 1 It is better to keep your html and css in different files because separating them improves performance since the browser parses the html and caches the css on subsequent visits

2 Every html document should have a main tag that encloses the main page contents change <div class="main"> To <main class="card"> This will change nothing visually but it makes all the difference. You can learn more about the main tag in this article

3 Remove the <div class= "attribution"> from the main and change it to <footer class="attribution"> And wrap it's text inside a p element.

I hope this helps

Happy coding 🙃

Marked as helpful

0

@SheikBazith

Posted

@rayaatta thank you for the suggestion. I will keep those in mind while doing other projects.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord