Simple QR Code

Community feedback

• 

  Baki Jessy Justice Julien•110

  @blackdreamer15Posted over 2 years ago

  Hi @YaSh8202! Congratulations on completing this challenge. I checked your code on GitHub and have some suggestions to make.

  1. You need to add the alt attribute to the img tag to solve the HTML issue.

  2. You have to use a <h3> tag instead of a <h3> tag to resolve one of the accessibility issues. Conventionally, you have to start with a level-one heading. (that is, the h1 tag)

  3. For the semantic reasons, it will be best to change <div class="center"></div> to <main class=""></main> since it contains the main content of the page.

  4. I think the <div class="card"></div> is not really important since you can apply the styles directly to the <main class=""></div>.

  5. For the <div class="attribution></div>, it will be best to use <footer class="attribution></footer> instead to resolve one of the accessibility issues.

  Good luck with your other challenges.

  Marked as helpful

  0