Design comparison
SolutionDesign
Community feedback
- @romila2003Posted about 2 years ago
Hi Caio,
Congratulations 🎉 for completing this challenge, the card looks. There are some issues I want to address:
- It is best practice to wrap the main content within the
main
tag which would ensure that your content is wrapped within the correct landmarks e.g.<main class="container"></main>
- When using the
ol
orul
tags, you must only nest theli
tags within it. In yourul
tag, you have adiv
which is causing accessibility issues.
Overall, great attempt and wish you the best for your future projects so keep coding 👍.
Marked as helpful0 - It is best practice to wrap the main content within the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord