Simple QR code page using flexbox.

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 6 months ago

  Hey @Squing0!

  Your solution is really impressive!

  I've got a couple of ideas (about how to use HTML better) that could make it even stronger:

  📌 First: Think about using <main> to wrap your main content instead of <div>.

  Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

  📌 Second: Consider using <h1> for your main title instead of <h2>.

  It's more than just text size — it's about structuring your content effectively:

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> is for the most important heading.
  • <h6> is for the least important heading.
  • Stick to just one <h1> per page – it should be the main title for the whole page.
  • And don't skip heading levels – start with <h1>, then use <h2>, and so on.

  These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.

  Hope that's helpful!

  Keep up the great work!

  Marked as helpful

  1
• 

  Bernardo Poggioni•5,280

  @R3ygoskiPosted 6 months ago

  Hello Lyle, congratulations on completing your project! It's very well done and closely resembles the proposed design.

  I noticed that in your footer, there are two <p> tags with text. They don't need to appear there; you can delete those <p> tags and leave only the div.attribution.

  Regarding your alignment approach, it's not incorrect, but you missed using some properties on your body tag, such as justify-content: center; and align-items: center, which would help center your card. Then, you can remove the margin: auto; from your div.mainSection.

  Another tip I'd like to give is about using semantic HTML. Your HTML structure is well done, but it lacks some semantics. For example, your div.imageContainer could be a <figure>. Semantic HTML like this significantly improves the accessibility of your project.

  Another tip, but this time regarding CSS, is when working with measurements, spacings, and font sizes. It's strongly recommended to use the rem unit because it can adapt to the user's font settings and provide responsive expansion or contraction of your element.

  Again, congratulations on completing this project so closely to the proposed design! Keep practicing and improving. If anything I said isn't clear, please ask below, and I'll try to help as best as I can.

  Marked as helpful

  1

  ---

  

  Lyle Patterson•60

  @Squing0Posted 6 months ago

  Thank you so much for the detailed feedback! I definitely should have used rem for the sizing of the section and I didn't even think to use the figure tag. Thank you also for the clarification on using flex with the body tag as that is what I was trying to do but couldn't figure out and went with margin: auto; instead.@R3ygoski

  1
• 

  Sivaprasath•2,520

  @sivaprasath2004Posted 6 months ago

  Hello, I would like to extend my congratulations on completing this challenge.

  • I will give some suggestion i believe its used for improve your solution result.
  • In HTML You will use the following tag omit the codes.

  <footer class="footerSection">
    `THIS IS SPOILED YOUR SOLUTION
  
  <p>Improve your front-end skills by building projects</p>
    <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
  
  OMIT THIS 2 <p> tag's`
  </footer>```
  

  Marked as helpful

  1