Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Simple QR code container with a description

@BartoszZ26

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Lucas 👾 104,400

@correlucas

Posted

👾Hello Bartosz, congratulations for you solution!

You solution is really well done, there's only two things to fix:

1.The img border-radius is a little bit smaller in comparisson to the container border, often the content inside the container should have a border-radius value 4px or 3px smaller than its container. In this case you've used 15px so 12px is a better fit.

2.Your card component isn't flexible and responsive due the width fixed you've set, use max-width in order to allow the card contract when the screen scales down.

figure {
    margin: 1rem 0;
    max-width: 250px;
    background-color: white;
    border-radius: 15px;
    padding: 1rem;
}

Hope it helps, happy coding!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord