Simple QR code component using HTML and CSS

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  Hello Rohit Deshpande, congratulations for your solution!

  Answering your question about responsiveness:

  I took a look on your code and I discovered why your card isn't flexible, this is due some properties unnecessary that you've add inside the container, there's no need to use min-height / min-width in this challenge, you've used also percentage that is a good unit, but % works better when you know the value of the element this percentage is related, in this challenge is hard to use percentage, to keep it more simple use px or even better rem.

  After deleting min-height / min-width from the .container, all have done to fix the card responsiveness was add max-width: 340px; and now its completely responsive even the qr code image.

  Try to apply this changes and say me then if work for you!

  I hope it help you and happy coding!

  0

  ---

  

  Rohit Deshpande•870

  @rohitd99Posted over 2 years ago

  @correlucas Again the feedback is on point as usual, I'll let you know the effects of the changes as soon as I apply them. Your comments are much appreciated.

  0