@denielden
Posted
Hello Kelly, You have done a good work! 😁
Some little tips to improve your code:
- use
main
tag to wrap the card and improve the Accessibility but not as a container of that one element - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - use
min-height: 100vh
to body instead ofheight
, otherwise the content is cut off when the browser height is less than the content - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
@KellyCHI22
Posted
Hi @denielden, thanks for your suggestions!
You are right, in real websites the main
part shouldn't contain only one single card! I've seperated the main
tag and the article
tag (which is for the card component).
As for the px
units, yes there are still some in my CSS, I've changed them to rem
s or em
s. It really takes some time to get used to total relative units!
Thanks again for your suggestions, they are truely helpful :)
@denielden
Posted
@Hsin-tingCHI you are welcome and keep it up :)