Simple QR Code Component

Community feedback

• 

  Adriano•38,390

  @AdrianoEscarabotePosted almost 2 years ago

  Hello Azel Alyne Tan, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  A document ought to have one primary landmark, and the absence of a main tag around the page's primary content is the root of this issue. On this page, there is no other element that is more important than the one that this challenge is based on, so to solve it, wrap all the content in the'main' tag.

  It's always a good idea to pay close attention to the proper use of semantic html elements because they are crucial for screen reader users to understand what the main content of the page is in the case of the'main' tag!

  To improve the responsiveness of the project, we can do this:

  .card {
      max-width: 280px;
  }
  

  Instead of using "width" to specify an absolute width, use "max-width" to specify a maximum instead. By doing this, the content will behave much more amiably in smaller resolutions, making it easier to make the project responsive.

  The remainder is excellent.

  I hope it's useful. 👍

  Marked as helpful

  0

  ---

  

  Azel Alyne Tan•40

  @azelalynetanPosted almost 2 years ago

  @AdrianoEscarabote. It was really helpful! :) I will now pay attention to semantic html elements and take note of the width. Thank you so much for the feedback, cant wait to update it and improve.

  1

  

  Adriano•38,390

  @AdrianoEscarabotePosted almost 2 years ago

  @azelalynetan no problem, happy coding!!

  1