Skip to content
Submitted about 2 months ago

Simple QR code component

Vigh Roland•40
@vighgiv
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

As this is my first project on Frontend Mentor, I’m proud of myself for starting this journey.

What challenges did you encounter, and how did you overcome them?

There weren't any.

What specific areas of your project would you like help with?

I welcome all feedback! 😊

The only thing that bothers me is that the text does not line up perfectly (not to mention the QR image).

Community feedback

  • Steven Stroud•11,910
    @StroudyPosted about 2 months ago

    Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…

    • Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. This should be a main <div class="text">.

    • Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset

    • Line height is usually unitless to scale proportionally with the font size, keeping text readable across different devices. Best practice is to use a unitless value like 1.5 for flexibility. Avoid using fixed units like px or %, as they don't adapt well to changes in font size or layout.

    I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻

    Marked as helpful
    1
    Vigh Roland•40
    @vighgivPosted about 2 months ago

    Thank you @Stroudy for letting me know about the unitless nature of line height. 💪

    I've also included the CSS reset file, which is handy when not using a framework like Tailwind.

    1
    Steven Stroud•11,910
    @StroudyPosted about 2 months ago

    Hey @vighgiv, I did the same until I got feedback aswell, You got this bro!

    1
  • Abdirahim Ali Mahamoud•380
    @asad102Posted about 2 months ago

    Looks similar, keep going, day by day you will gain new technique

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord