@Stroudy
Posted
Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…
-
Using a
<main>tag inside the<body>of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. This should be a main<div class="text">. -
Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset
-
Line height is usually unitless to scale proportionally with the font size, keeping text readable across different devices. Best practice is to use a unitless value like
1.5for flexibility. Avoid using fixed units likepxor%, as they don't adapt well to changes in font size or layout.
I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻
Marked as helpful
@vighgiv
Posted
Thank you @Stroudy for letting me know about the unitless nature of line height. 💪
I've also included the CSS reset file, which is handy when not using a framework like Tailwind.
@Stroudy
Posted
Hey @vighgiv, I did the same until I got feedback aswell, You got this bro!
