Simple QR Code Card

Community feedback

• 

  Daniel 🛸•44,270

  @danielmrz-devPosted 10 months ago

  Hello @Ali-AK004!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • In order to make your HTML code more semantic, and since that is the main title of the screen, you can replace the <h3> with <h1>. Unlike what most people think, it's not just about the size and weight of the text.

  The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1

  ---

  

  Ali-AK004•190

  @Ali-AK004Posted 10 months ago

  Hi Again @danielmrz-dev thank you for reminding me with that , totally appreciate it <3

  1
• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  Hey @Ali-AK004! this looks really good 😎

  I just have some suggestions and some questions:

  • I recommend doing a small reset to the styles that come by default in the browsers. To do this, you can apply a couple of properties to the universal selector *, with this you will make your site look the same in all browsers:

  * {
      margin: 0;
      box-sizing: border-box;
  }
  

  • I leave you the task of researching the reset CSS and the box-sizing: border-box
  • Do not use height: 100vh instead use min-height: 100vh this will prevent the content from being cut off on certain occasions
  • You have applied overflow: hidden to the body. For what?
  • You have defined max-width: 100% in the container class, there you also defined max-width: 375px overwriting what was defined a few lines above (If the properties are the same, CSS takes the one you have set below). Therefore, max-width: 100% is unnecessary.
  • You've also defined width: fit-content. What does that do?

  Marked as helpful

  1

  ---

  

  Ali-AK004•190

  @Ali-AK004Posted 10 months ago

  Hi Again <3@Blackpachamame Thank You man , That Was One Of The First challenges I Did <3

  1