Design comparison
Solution retrospective
Remembering how to code I took a long break from it
What challenges did you encounter, and how did you overcome them?Just remembering syntax
What specific areas of your project would you like help with?None right now, this was more to get used to coding again
Community feedback
- @Islandstone89Posted 6 months ago
Hi, great job!
Some suggestions:
HTML:
-
The alt text must also say where it leads(frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."
-
I would change the heading to a
<h2>
- a webpage can only have one<h1>
, which is reserved for the main heading. As this is a card heading, it would likely not be the page's main heading.
CSS:
-
I like to add
1rem
ofpadding
on thebody
, to ensure the card doesn't touch the edges on small screens. -
It is common to add
display: block
andmax-width: 100%
on images. -
As the design doesn't change, there is no need for any media queries. When you do need them, they should be in
rem
orem
, not px.
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord