Design comparison
Solution retrospective
I am proud of myself for using the `` tags and understanding their functions more precisely.
What specific areas of your project would you like help with?-
Is the code well organized ?
-
Is the accessibility used sufficient ?
-
What are the possible improvements ? (I will soon start using SCSS)
Community feedback
- @DacardonacPosted 3 months ago
Hello MrLanter, I hope you are doing very well. I was reviewing your solution, and I want to congratulate you for the excellent work you sent. Everything is good. I only see one point to improve in your project, and I want to give you some feedback.
-
Check your HTML and its Semantics, you have a header tag inside a div tag that is inside the main tag, which is wrong semantically, here I let you a link where you can read about that: HTML Semantic Elements
-
Another point is that as a recommendation, you can save lines of code by using the modularized styles with Sass.
That's all, the project in general is super good, congratulations MrLanter!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord