@MelvinAguilar
Posted
Hi @Kaji17 👋, good job for completing this challenge and welcome to the Frontend Mentor Community! 🎉
Here are some suggestions to improve your code:
- Try to use semantic tags in your code. More information here:
With semantic tags:
<body>
<main class="main-content">
. . .
</main>
. . .
<body>
-
Don't use
<br>, the<br>tag is not semantic. It should never be used to add vertical spacing, it is only used in specific cases (e.g. poem or an address) also when a screen-reader reads the text it will break the text at the<br />tag and break the flow of reading, You could use padding or margin styling via CSS to avoid them. More Information here. -
Add a
<h1>tag in your solution, The<h1>element is the main heading in a web page. There should only be one<h1>tag per page, and always avoid skipping heading levels; always start from<h1>, followed by<h2>and so on up to<h6>(<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)
Solution:
<h1>Improve your front-end skills by building projects</h1>
- Use
max-width: 324pxto.main-contentselector instead of width. - Use
min-height: 500pxto.main-contentselector instead of height.
I hope those tips will help you.
Good Job and happy coding !
@Kaji17
Posted
@MelvinAguilar thanks, i follow all your advice sensei :)
