Design comparison
SolutionDesign
Solution retrospective
This is my first submission here, any suggestions?...and uh what kind of semantic tags would you use instead of the divs if you have coded this?
Community feedback
- @ccreusatPosted about 3 years ago
Hey ! Nice work.
You could replace :
- div.main-container with a <main> tag
- div.description with a <p> tag
- div.annual-plan-text with a <strong> tag
- div.money with a <span> tag
You could add :
- type="submit" on your button tag as it would submit the form
By doing so, you could replace div.text-container by a <form> tag
Marked as helpful0 - @Heathallred4Posted about 3 years ago
The only thing I would do differently, is use the <main> tag in place of the <div class=main-container>. And possibly use <footer> for the payment and cancel buttons. Those are the only two I noticed, but I'm fairly new at all of this as is. It looks really clean though.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord