Design comparison
SolutionDesign
Solution retrospective
Open any feedback guys.
Thank you.
Community feedback
- @MelvinAguilarPosted about 2 years ago
Hi @bajra03๐, good job on completing this challenge! ๐
Here are some suggestions you might consider:
- You could use the CSS backgrounds properties to set the background:
body { . . . background-color: var(--primary-pale-blue); background-image: url(./images/pattern-background-desktop.svg); background-repeat: no-repeat; background-position: left top; }
background-color
Set the background color.background-image
Set a background image.background-repeat
Sets if a background image will be repeated along the horizontal and vertical axes, or not repeated at all.background-position
Sets the starting position of a background image.- You can also specify the size of the background image with background-size
The background property is shorthand for all the properties mentioned above:
background: var(--primary-pale-blue) url(./images/pattern-background-desktop.svg) no-repeat left top;
References:
- The music icon is for decoration purposes only, so it could be hidden from screen readers by adding aria-hidden="true" and leaving its alt attribute empty:
<img src="./images/icon-music.svg" alt aria-hidden="true">
I hope those tips will help you.
Good job, and happy coding!
2@bajra03Posted about 2 years agoHi @MelvinAguilar ,
I just forget about the background in body element, thank you for remind me, and also I will update the music icon to
aria-hidden="true"
Thank you.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord