@rayaatta
Posted
Hello SheikBazith 👋, congratulations on completing another challenge 🎉 Here are some tips that can help improve your code.
1
Since the button is a clickable element
Add
cursor:pointer;
To it in css
2
I noticed you have two h1s in your code.
Here's a quick guide on how to use them:
The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on.
You can then style them in you css.
Unlike what most people think, it's not just about the size and weight of the text
3
In order to make your solution look closer to the design replace
background-size: cover;
with
background-size;contain;
I hope this helps
Your solution looks great 😉
@danielmrz-dev
Posted
Hello @SheikBazith!
Your solution looks great!
I have a suggestion for improvement:
- For semantic reasons, use
mainto wrap the main content instead of adiv. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful
@SheikBazith
Posted
@rayaatta I forgot to add the cursor: pointer will keep that in mind. Will make sure to use the headings tags properly from now on. I have been using cover assuming thats the best way to do it. Thank you will learn to use contain from now on.
@SheikBazith
Posted
@danielmrz-dev Will keep that in mind next time I do it. Thank you
