Design comparison
Community feedback
- @grace-snowPosted over 3 years ago
Hi
All your text on this is in divs instead of meaningful elements. Text cannot be in divs/spans alone it needs to use elements with appropriate semantics. Really important.
Also some of these images need alt textand shouldn't be left blank.
I recommend you don't move onto another challenge until html is sorted in this and any other challenges you've done so far, as this stuff will really start to compound in larger challenges if you don't solidify these foundations now.
I hope this helps.
0@gfontorbePosted over 3 years agoAs usual, very informative comments!
I will study the solution you uploaded for the "Testimonials grid section" challenge. Looks like I can learn a lot from it.
Then I'll have a go at reworking my previous submission.
Thanks for your time once again!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord