Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Simple HTML+CSS solution

Balazs Feherā€¢ 20

@balazs97feher

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  1. Are there any accessibility considerations here other than providing an alt text for the image?
  2. Are there other HTML elements that would better convey the semantics of this component?
  3. The mobile and desktop designs look pretty much identical to me, I'm guessing it's the first challange. If not, would it be as easy as ussing a few media queries, say for widths below and above 800px?

Community feedback

Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello @balazs97feher!

Your solution looks great!

I have a couple of suggestions (about semantic HTML) for improvement:

šŸ“Œ First: Use <main> to wrap the main content instead of <div>.

Think of <div> and <span> in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.

šŸ“Œ Second: Use <h1> to <h6> for titles instead of <div>.

Like I said, <div> and/or <span> don't have any semantic value. For titles, we have the HTML headings (the tags <h1> to <h6>).

Here's a quick guide on how to use them:

Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

1

Balazs Feherā€¢ 20

@balazs97feher

Posted

@danielmrz-dev Thanks a lot!

1
verakissyou17ā€¢ 380

@verakissyou17

Posted

Hey, ** Balazs**! Congratulations for your project!! Instead of this:

   <div class="qr-code-heading">
       Improve your front-end skills by building projects
     </div> 

I would use an h1 tag:

<h1> Improve your front-end skills by building projects</h1>
0

Balazs Feherā€¢ 20

@balazs97feher

Posted

Thank you! @verakissyou17

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord