Design comparison
Solution retrospective
I would be happy for any feedback, trying to improve my css skills to start playing around with css-in-js in future
Community feedback
- @rnguecoPosted over 3 years ago
Hey Łukasz!
Great job on this. 👍
I have only one thing to point out: when viewing the site on mobile landscape, the image starts overflowing towards the top and gets cut off. This is because you've set your body's
height
to100vh
which means it will not expand to accommodate overflowing content. What you want instead is amin-height
of100vh
.Cheers and happy coding! 🎉
Marked as helpful1@arctindevPosted over 3 years ago@rngueco Ty very much for feedback :D noticed the mistake n solved it just as u said :D also added some 10vh margins on mobile viewport to improve card overall visibility :D Cheers!! Have a great day!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord