simple html and css page

Community feedback

• 

  Adriano•38,060

  @AdrianoEscarabotePosted almost 2 years ago

  Hi CyPhEr420, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  As you know this project is based only on one page component, so no h1 is needed! because we don't know if this page will have a more important component, but it's always good to prevent accessibility errors so I think it would be good for you to add an h1 in this component, besides being a good practice for when you are developing larger sites, don't worry forget about h1.

  <h1 class="qr-title">Improve your front-end skills by building projects</h1>

  Add a padding to the body, so that the content in lower resolutions doesn't hit the edge of the screen!

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  CyPhEr420•400

  @CyPhEr420Posted almost 2 years ago

  @AdrianoEscarabote thnx for that am just starting to focus more on the accessibility

  1
• 

  Edwin Boon•30

  @brwmasterPosted almost 2 years ago

  Hello, Nice work! 😁

  Here is a little feedback to improve the code even more

  • Wrap all your code in <main></main> tags
  • Change the div class="title"> to a `<h1 class="title">
  • Change the div class="text"> to a <p class="text"> or just style the <p></p>`
  • Add a . to the end of the alt text to improve Accessibility

  And some advice I got on my solution is to change all the px values to rem values. link here

  I hope this feedback will help you!

  Marked as helpful

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0

  ---

  

  CyPhEr420•400

  @CyPhEr420Posted almost 2 years ago

  @denielden so should I be using rem for height, widths, and sizes oo and the padding, margin all those

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @CyPhEr420 you are welcome and keep it up :)

  Yea rem it's good for all

  0

  

  CyPhEr420•400

  @CyPhEr420Posted almost 2 years ago

  @denielden thx

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @CyPhEr420 you are welcome and keep it up :)

  0