Simple CSS QR-code component

Community feedback

• 

  Renan Rodrigues•960

  @irenanrodriguesPosted about 1 year ago

  Olá Pamella, tudo bem? Ao meu entendimento está tudo certo. Parabéns novamente.

  Recomendo não usar height na classe main-container, use o min-height, para alcançar a altura desejada.

  Apenas com o height, você está definindo uma altura fixa, para seu elemento. Faça um teste com o DevTools, para ver as diferenças.

  Marked as helpful

  0

  ---

  

  Pamella Oliveira Conte•100

  @PamellaoliveiracontePosted about 1 year ago

  Valeu pelas dicas @irenanrodrigues!

  0
• 

  Mennatallah Hesham•1,490

  @Mennatallah-HishamPosted about 1 year ago

  Hi Pamella,

  Congratulations on completing your first challenge👏

  You did great 👍

  Here are some suggestions to improve your code:

  Semantic HTML

  • wrap your card in <article>

  <main>
  <article>
  </article>
  <div>
  </div>
  </main>
  

  ALT

  • images should have descriptive alt text, which is important for SEO and screen reader users,alt="QR code linking to Frontend Mentor challenges"

  SEO

  • you can add meta description for better SEO, it provides a brief summary of a web page

  <meta name="description" content="..........."/>  
  

  here are some helpful articles:

  • alt text
  • meta description

  Hope you find this helpful, Happy Coding

  Marked as helpful

  0