Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

simple css positioning

Melaku Demekeβ€’ 30

@MelakuDemeke

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Travolgi πŸ•β€’ 31,420

@denielden

Posted

Hello Melaku, You have done a good work! 😁

Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • img element must have an alt attribute, it's very important!
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • remove all margin from .maincontainer class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

Keep learning how to code with your amazing solutions to challenges.

Hope this help πŸ˜‰ and Happy coding!

Marked as helpful

1

Stevo_Dev Repoβ€’ 560

@A-pixel-ux

Posted

@denielden let's chat

1
Adebisiβ€’ 330

@adebisiabdussamad

Posted

Cheers MelakuπŸ₯‚ on completing this challenge.. .

An img element must have an alt attribute. This enables physical challenge to understand the image better.

-This is your code:<img src="./images/image-equilibrium.jpg">

-This is how it should be:<img src="./images/image-equilibrium.jpg" alt="">the second one with the alt attritube

your code is really amazing...hope you find this helpful...

Happy coding!!!πŸ‘ŒπŸ‘

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord