Design comparison
Community feedback
- @denieldenPosted about 2 years ago
Hello Melaku, You have done a good work! π
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility img
element must have analt
attribute, it's very important!- add descriptive text in the
alt
attribute of the images - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - remove all
margin
from.maincontainer
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help π and Happy coding!
Marked as helpful1 - add
- @adebisiabdussamadPosted about 2 years ago
Cheers Melakuπ₯ on completing this challenge.. .
An img element must have an alt attribute. This enables physical challenge to understand the image better.
-This is your code:
<img src="./images/image-equilibrium.jpg">
-This is how it should be:
<img src="./images/image-equilibrium.jpg" alt="">
the second one with the alt attritubeyour code is really amazing...hope you find this helpful...
Happy coding!!!ππ
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord