Skip to content
Submitted about 2 years ago

Simple CSS positining and styling

Yojan kaphle•70
@yozan21
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    Hi @Hante20 👋, good job on completing this challenge! 🎉

    Here are a few suggestions I've made that you can consider in the future if you're looking to improve the solution further.:

    With semantic tags:

    <body>
   <main class="body">
      . . .
   </main>
<body>
    • Setting element width with percentages or VW will cause your component to behave weirdly on mobile devices and high-resolution desktops. You can set the width at 320px or 20rem:
    * {
    box-sizing: border-box;
}

.body {
    /* width: 21%; */
    max-width: 320px;
    background-color: hsl(0, 0%, 100%);
    /* position: relative; */
    /* top: 2rem; */
    /* left: 27rem; */
    padding: 1rem;
    border-radius: 5%;
}
    • The <div> tag defines a division or section on a website. It is used to style a container with CSS, set special alignment, or position content. It might be more efficient to use the <p> tag; the <p> element represents paragraph-level content, usually text:
    <p class="text">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    • Add an h1 tag to your solution. The <h1> element is the main heading on a web page. There should only be one <h1> tag per page, and always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)

    Solution:

    <h1 class="bold-text">Improve your front-end skills by building projects</h1>
    • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
    • Centering the element with position would make your element behave strangely on some mobile devices. You can use flexbox to center elements:
    body {
  margin: 0;
  min-height: 100vh;
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
}

    Links with more information:

    Overall well done! I hope those tips will help you.

    Good job, and happy coding!

    Marked as helpful
    1
  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hi @Hante20, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
    • Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
    • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord