Melvin Aguilar 🧑🏻💻• 61,220
@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML 🏷️:
- Use semantic elements such as
<main>and<footer>to improve accessibility and organization of your page.
CSS 🎨:
- Use
min-height: 100vhinstead ofheight. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
3
Mohammad-Moneer• 100
@Mohammad-Moneer
Posted
@MelvinAguilar I am glad to get the first and valuable comment on my first project on Frontend Mentor, I really think I will have a very useful experience here. Thank you so much, I will soon update this solution taking in consideration your appreciated notes.
0
