Design comparison
Solution retrospective
Please feel free to write your opinion on the challenge. I really look forward to hearing from you. Please let me know anything that I'm missing. Thank you.
Community feedback
- @FahatmahPosted over 2 years ago
Great work there!
I just see in your report that you have some accessibility issues. Main issue is not using semantic HTML which are
main
,section
,footer
and this will avoid the issues in your code. Although you usedsection
tag, it shoud have themain
tag first. But nice job done there. Hope this helps you.Marked as helpful1@satya-hashPosted over 2 years ago@Fahatmah Thank you for the feedback. And I try my best to resolve the issues and improve my skills.
1 - @vanzasetiaPosted over 2 years ago
Hello, @satya-hash! 👋
Good effort on this challenge! 👍
Some recommendations from me.
- Always specify the
type
of thebutton
. In this case, set the type of them astype="button"
. It will prevent the button from behaving unexpectedly (like submitting). - The value for the
href
attribute of<a href="*">Change</a>
is visiting to "Page Not Found". I would recommend using a number sign or forward slash instead. - There should not be text in
span
anddiv
alone whenever possible. Instead, wrap the text with a meaningful element like a paragraph element.
That's it! I hope you find this useful! 😊
Marked as helpful0@satya-hashPosted over 2 years ago@vanzasetia Thank you for your help and support. I will try my best to correct my mistakes and improve my skills 🙂.
0 - Always specify the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord