Simple card using html and css.

Community feedback

• 

  pierre-pellegrino•970

  @pierre-pellegrinoPosted over 3 years ago

  Hey, This is looking great !

  First issue, you forgot to include 'images' folder on your Github repo, that's why it's not showing. :)

  For adding color to the picture, I did something a bit different than you : I created an empty div in my html called <div class="bg-img">, and added this in my css :

  .bg-img {
    background-image: linear-gradient( rgba(79, 2, 137, 0.6), rgba(79, 2, 137, 0.6) ), url('images/image-header-desktop.jpg');
    background-size: cover;
  }
  

  It ends up with a filter of rgba(79, 2, 137) (violet) color to apply on my picture with an opacity of 0.6. I don't know if it's the best way of doing it but I think it does the job pretty well.

  Good luck and happy coding !

  1

  ---

  

  Maddy•45

  @maddy1381Posted over 3 years ago

  @PierreWagon Thanks for your valuable feedback. Actually I used GitHub for the first time for this project so couldn't find a way to include it😅.

  Thank you for sharing the code :)

  0

  

  pierre-pellegrino•970

  @pierre-pellegrinoPosted over 3 years ago

  @maddy1381 I know that feel, I discovered Github a few weeks ago and was completely lost !

  Once you get it it's pretty simple :

  1. Go to your repository (https://github.com/maddy1381/webpage)

  2. Click on "Add file" > "Upload files"

  3. You just have to drag and drop the "images" folder you downloaded from frontendmentor

  Good luck !

  0

  

  Maddy•45

  @maddy1381Posted over 3 years ago

  @PierreWagon okay I will try it :)

  0