Design comparison
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Ellie Aghajani, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Every pages needs a
<h1>
to show which is the most important heading. So replace the<h2>
with<h1>
and follow the sequence h1-h5The rest is great!!
Hope it helps...👍
0 - @correlucasPosted about 2 years ago
👾Hi , congratulations on your first solution!
I’ve few suggestions for you that you can consider adding to your code:
1.Replace the
<h2>
containing the main title with<h1>
note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.2.Use relative units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.3.The correct value for this shadow is
box-shadow: 5px 5px 15px 5px rgb(0 0 0 / 3%);
✌️ I hope this helps you and happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord