Design comparison
Solution retrospective
i was able to write most of the html code without looking at other work. i was impressed with the media queries in CSS and how my webpage fitted on my phone web. next time, i would give myself more time to play around with CSS
What challenges did you encounter, and how did you overcome them?i could not create the mobile version of the application. i then looked up for some solutions on the internet
What specific areas of your project would you like help with?i would like more help in CSS, i still have a long way to go despite grasping the basics in theory
Community feedback
- @UnifiesPosted 3 days ago
Hi there, Takomborerwa. Great work completing your first challenge on Frontend Mentor, your solution to the challenge looks good. Kudos on overcoming the challenge you had, because the layout & mobile view of your solution looks great and responsive on all active screen widths.
A couple updates for better code quality:-
Include semantic HTML and a level one heading in your code - It is best practice to contain all content within distinct regions such as the
<header>
,<nav>
,<main>
, and<footer>
. Here's a guide to the full doc that explains this.Your solution differs slightly from the design because you have the
<attribution>
code in the QR Code Component. That is the part with the "Challenge by, Coded by", it's supposed to come underneath the solution OUTSIDE the white qr_code div but within the body inside the "attribution" div. This will of course mean you have to rewrite the stylings for the attribution section so that it looks as it should.Marked as helpful1 - @AhmedMahmoud6Posted 2 days ago
Well Done, you can make the spacing between the elements more cleaner and easier by using the display flex on the parent and use the following code or try to see my solution
display: flex; flex-direction: column; gap: 20px; // change the pixels as you want
this is more cleaner than giving each element a margin top or bottom.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord