Simple and responsive landing page using CSS

Community feedback

• 

  Wisdom•180

  @UnifiesPosted 20 days ago

  Hi there, Takomborerwa. Great work completing your first challenge on Frontend Mentor, your solution to the challenge looks good. Kudos on overcoming the challenge you had, because the layout & mobile view of your solution looks great and responsive on all active screen widths.

  A couple updates for better code quality:-

  Include semantic HTML and a level one heading in your code - It is best practice to contain all content within distinct regions such as the <header>, <nav>, <main>, and <footer>. Here's a guide to the full doc that explains this.

  Your solution differs slightly from the design because you have the <attribution> code in the QR Code Component. That is the part with the "Challenge by, Coded by", it's supposed to come underneath the solution OUTSIDE the white qr_code div but within the body inside the "attribution" div. This will of course mean you have to rewrite the stylings for the attribution section so that it looks as it should.

  Marked as helpful

  1
• 

  Ahmed Zaki•30

  @AhmedMahmoud6Posted 19 days ago

  Well Done, you can make the spacing between the elements more cleaner and easier by using the display flex on the parent and use the following code or try to see my solution

  display: flex;
  flex-direction: column;
  gap: 20px; // change the pixels as you want
  

  this is more cleaner than giving each element a margin top or bottom.

  0