Submitted almost 3 years ago
Simple 3 Column card Component using BEM CSS Format
@Jeth0214
Design comparison
SolutionDesign
Solution retrospective
Kindly check if my solution on how I solved the changes of border-radius from small device to medium devices was correct. Thanks
Community feedback
- @nikosAndr13Posted almost 3 years ago
Some things I would like to point out:
- A good practice for your HTML is to make everything classes or id just so you can focus and increase the specificity
- Now you had only a few images so it wasn't a problem, but when you put let's say 25 imgs in a folder you need to make a half/full step: The syntax: <img src="./images/icons/one-image.png">
- For the mobile responsiveness I would recommend finding the most common screen sizes and stick to that: for PC 1200px, iPad 768px iPhone 320px etc I hope I helped! Keep grinding!
1 - @RioCantrePosted almost 3 years ago
Hello! Great job on this one! Your solution is pretty much the same to the original design. The border-radius looks fine during the transition to smaller devices. Nothing much to say but I could suggest the following for you:
- Adjust the height on the
.container
to make it appear longer. - Add a padding or margin around the paragraph inside the
.attribution
in order to give it enough space on smaller screen view.
These are just very minor enhancement. Overall the project you made is on point. Keep it up!
1 - Adjust the height on the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord