Sign-up-card-comp-AtlasKaplan / HTML/CSS/Basic JS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 1 year ago

  Hello, Atlas K! 👋

  You should not position your attribution at the top of the main content. Also, it can not be a <header> of the page. <header> should be used to wrap content like logo and navigation links. You should use <footer> instead.

  Your attribution should go below the main content. In other words, it should be after the <main> landmark.

  I don't think "Try it free 7 days then $20/mo. thereafter" is a <button>. For me, it is just a banner above the form for promotion.

  Each <input> must have a label or accessible name. Since there is no visible label on the design, I recommend using aria-label to label each input.

  Use CSS to uppercase the text. Screen readers might spell the uppercased word in the HTML (spelled letter by letter).

  <input> with type="submit" is a legacy element. It was used before the <button> element exist. It is best to avoid using legacy elements. So, use <button> element instead.

  I recommend trying to create custom form validation with JavaScript. If you try it you can learn more about JavaScript. Also, I recommend using const or let instead of var.

  Learn how to create custom form validation — How To Create Accessible Form with Boring Design? - CodeNewbie Community 🌱

  I hope you find this useful. Happy coding! 😄

  Marked as helpful

  1