Sign-up page using Sass

Community feedback

• 

  David•8,000

  @DavidMorgadePosted about 2 years ago

  Hello F5rcbh! congrats on finishing the challenge, your form looks pretty good in my opinion

  If you don't mind I would like to give you some feedback:

  • Regarding the styles they seem good for me, probably chaging the breakpoint from your media querie to 900~px because the layout breaks at 700 to 900px, with the changes it should keep the mobile design until 900px fixing that problem!!

  • For the html try using more semantic tags, you could use a main to wrapp all the content instead of div also divided it in 2 sections (one for the form, the other for the text), getting this will improve the accesibility to your page, making it easier for search engines and positioning it better!

  Hope my feedback helps you! if you have any questions, don't hesitate to ask anything! great job

  Marked as helpful

  1

  ---

  

  f5rcbh•190

  @f5rcbhPosted about 2 years ago

  @DavidMorgade thx for the feedback mr David i will consider everything you said and I will try to improve myself more better than this <3

  1