@PhoenixDev22
Posted
Hi DarkDev56,
Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:
- Forms with proper inputs and labels are much easier for people to use. To pair the label and input, one way is an explicit label’s
for
attribute value must match its input’sid
value. Input fields without accompanying labels can lead to accessibility issues for those who rely on screen readers. If a screen reader comes across an input field without a label it will try to find some accompanying text to use as the label. (To hide the label visually but present for assistive technology, you may usesr-only
class ).
- The
aria-live
attribute is set on that error messageclass="error-text
to make sure that error message will be presented to everyone, including it being read out to ** screen reader users**.
- Really important to keep css specificity as low/flat as possible. It’s not recommended use the id's to target the DOM elements for styling purposes , using ID's creates problems due to the specificity , better to use class so that it could be more manageable and reusable.
Hopefully this feedback helps.
Marked as helpful
@dotfivesix
Posted
@PhoenixDev22 Thanks for appreciating my solution and providing feedback. It means a lot to me and helps me a lot to improve ! I will take care of id
and aria-live
next time.
@PhoenixDev22
Posted
@DarkDev56 Glad to hear that it was helpful . Happy coding